Skip to content

fix: preserve Windows drive-letter and colon-containing paths when parsing import artifact flags - #588

Merged
yada merged 2 commits into
microcks:masterfrom
aniket866:fix/import-windows-path-colons
Oct 27, 2026
Merged

fix: preserve Windows drive-letter and colon-containing paths when parsing import artifact flags#588
yada merged 2 commits into
microcks:masterfrom
aniket866:fix/import-windows-path-colons

Conversation

@aniket866

@aniket866 aniket866 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Fixed the import flag parser: it now strips only a trailing parseable boolean suffix, preserving Windows drive letters and other colons in file paths.

verification:

  • A small regression test is warranted for this parser bug, especially because the key case is Windows-specific but the parsing is platform-independent, the tiny parsing step so a table-driven test can cover the Windows path, :false, relative paths, and a colon-containing filename; no broader test scaffolding.

AI disclosure : ChatGpt is used to analyze related files and changes.

Closes #352

@aniket866
fix: preserve colons in import file paths
b2bf7f6 
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@aniket866
fix: cover colon-containing import paths
22d3169 
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@yada yada mentioned this pull request Oct 17, 2026
Closed
@yada

yada commented Oct 27, 2026

Copy link
Copy Markdown
Member

Verified head 22d3169 locally: builds, go vet and go test ./... pass. I ran a 9-case path matrix (relative, absolute, :false, :true, Windows drive letter such as C:\specs\api.yaml, colon in filename, and combinations) against master and the PR: no regression, and the drive-letter and colon-in-name cases are now preserved. I could not run on real Windows, but the parsing is platform-independent and covered by the table-driven test.

Disclosure: this comment was drafted with AI assistance, and the results were run locally.

yada
yada approved these changes Oct 27, 2026
View reviewed changes

@yada yada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally. Disclosure: AI-assisted verification.

@yada
yada merged commit 99b2947 into microcks:master Oct 27, 2026
7 checks passed
This was referenced Oct 27, 2026
Closed
Open

This branch was successfully deployed

1 active deployment
Build — 22d31691 Deployed Oct 15, 2026 by aniket866 via build-verify-package #809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yada yada yada approved these changes
@lbroudoux lbroudoux Awaiting requested review from lbroudoux lbroudoux is a code owner
@Harsh4902 Harsh4902 Awaiting requested review from Harsh4902 Harsh4902 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

microcks import truncates Windows absolute paths when parsing :primary suffix

2 participants

@aniket866 @yada